Fix records with function calls for default values failing code generation

[Thushara-Piyasekara]

Purpose

Fixes #43531

Remarks

The codegen failure was due to corrupted BIRInstructions originated from BIRRecordValueOptimizer. BIRRecordValueOptimizer tries to optimize default functions with other function invocations inside their bodies. This was fixed by updating the logic used to identify functions with only constant loads.

Check List

• Read the Contributing Guide
• Updated Change Log
• Checked Tooling Support (#)
• Added necessary tests
  • Unit Tests
  • Spec Conformance Tests
  • Integration Tests
  • Ballerina By Example Tests
• Increased Test Coverage
• Added necessary documentation
  • API documentation
  • Module documentation in Module.md files
  • Ballerina By Examples

[Thushara-Piyasekara]

@HindujaB could you point out the location where the tests for the following class is located?

ballerina-lang/compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/optimizer/BIRRecordValueOptimizer.java

Line 50 in 5c9cc32

public class BIRRecordValueOptimizer extends BIRVisitor {

I tried searching but couldn't find a place. In case there are no tests for that class, could you suggest a place to add the sample test mentioned in #43531?

[HindujaB]

@HindujaB could you point out the location where the tests for the following class is located?

ballerina-lang/compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/optimizer/BIRRecordValueOptimizer.java

Line 50 in 5c9cc32

public class BIRRecordValueOptimizer extends BIRVisitor {

I tried searching but couldn't find a place. In case there are no tests for that class, could you suggest a place to add the sample test mentioned in #43531?

As this is covered in default value creation for record fields, we didn't add specific tests.
You can add unit tests here - https://github.com/ballerina-platform/ballerina-lang/blob/master/tests/jballerina-unit-test/src/test/java/org/ballerinalang/test/record/RecordWithClosureTest.java

[codecov]

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.56%. Comparing base (06e7fa7) to head (6a957cc).
Report is 392 commits behind head on master.

Files with missing lines	Patch %	Lines
...ompiler/bir/optimizer/BIRRecordValueOptimizer.java	66.66%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #43563      +/-   ##
============================================
- Coverage     77.56%   77.56%   -0.01%     
  Complexity    58741    58741              
============================================
  Files          3448     3448              
  Lines        219678   219679       +1     
  Branches      28918    28919       +1     
============================================
- Hits         170394   170391       -3     
- Misses        39892    39897       +5     
+ Partials       9392     9391       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Thushara-Piyasekara]

The 1 line that is missing coverage is not a change done in this PR. @rdulmina do we have to add tests for that as well?

Also could you try rerunning the stdlib level 6? It is passing in other PRs now. Whatever was failing in that repo might be fixed now.

[HindujaB]

LGTM