Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Incorrect quick fix for invalid access of a mutable field of an 'isolated' object outside a 'lock' statement #41331

Closed
rdulmina opened this issue Sep 4, 2023 · 2 comments
Labels
Area/CodeAction Language Server Code Actions Reason/Invalid Issue is invalid. Team/LanguageServer Language Server Implementation related issues. #Compiler Type/Bug

Comments

@rdulmina
Copy link
Contributor

rdulmina commented Sep 4, 2023

Description

Screen.Recording.2023-09-04.at.11.06.00.mov

This suggests Extract to local variable as a quick fix which is incorrect. Wrapping the statement inside a lock statement may be a good quick fix

Steps to Reproduce

No response

Affected Version(s)

No response

OS, DB, other environment details and versions

No response

Related area

-> Editor

Related issue(s) (optional)

No response

Suggested label(s) (optional)

No response

Suggested assignee(s) (optional)

No response

@rdulmina rdulmina added Type/Bug Team/LanguageServer Language Server Implementation related issues. #Compiler Area/CodeAction Language Server Code Actions labels Sep 4, 2023
@malinthar
Copy link
Contributor

malinthar commented Oct 16, 2023

This is not a quick fix. This extract to variable code action is a extract type code action. This issue is invalid!

@mindula mindula closed this as completed Oct 16, 2023
@mindula mindula added the Reason/Invalid Issue is invalid. label Oct 16, 2023
@github-actions
Copy link

This issue is NOT closed with a proper Reason/ label. Make sure to add proper reason label before closing. Please add or leave a comment with the proper reason label now.

      - Reason/EngineeringMistake - The issue occurred due to a mistake made in the past.
      - Reason/Regression - The issue has introduced a regression.
      - Reason/MultipleComponentInteraction - Issue occured due to interactions in multiple components.
      - Reason/Complex - Issue occurred due to complex scenario.
      - Reason/Invalid - Issue is invalid.
      - Reason/Other - None of the above cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/CodeAction Language Server Code Actions Reason/Invalid Issue is invalid. Team/LanguageServer Language Server Implementation related issues. #Compiler Type/Bug
Projects
None yet
Development

No branches or pull requests

3 participants