[Bug]: NodeFinder returns null for a SimpleNameReferenceNode

[DamithaSenevirathne]

Description

Consider following code sample

public function main() returns error? {
   ProductClient prodClient = check new("http://example,com");
   string v = prodClient->
}

Here if we try to get the BLangNode related to prodClient using NodeFinder it returns null node

Steps to Reproduce

1. get the node considering the line position (line position within the prodClient)
2. get the lineRange() for the considered node (this is a SimpleNameReferenceNode)
3. try to get bLangNode using nodeFinder.lookup(bLangCompilationUnit, node.lineRange())

Affected Version(s)

No response

OS, DB, other environment details and versions

No response

Related area

-> Compilation

Related issue(s) (optional)

No response

Suggested label(s) (optional)

No response

Suggested assignee(s) (optional)

No response

[sanjana]

The prodClient-> is parsed as a ASYNC_SEND_ACTION node in the BLangNodeBuilder.
This is not yet supported. Awaiting changes from #24849.

@lochana-chathura are there any workarounds temporarily for this?

[lochana-chathura]

As a temporary workaround, we could set the position of the mocking BLangExpression node to have prodClient->'s position.

Then, I guess the null pointer will be gone. You will have the mocking BLangExpression from the NodeFinder.

[lochana-chathura]

Although the null return is gone. I think it won't be helpful get the expectedType since we replace the prodClient-> part with a mocking simple variable node. :(

[lochana-chathura]

Depends on PR #38245

[DamithaSenevirathne]

This is a requirement for expectedType API implemented in the semantic API, In this case expectedType API is unable to provide the correct expectedType because we are not getting the correct node type. Returning mocking simple variable node won't be helpful in this case.

[sanjana]

Since the suggested workaround doesn't fulfill the requirement of the Expected Types API, decided to await the changes from #38245. Once it is completed, can check from the Semantic API to validate this case.