[Bug]: Incorrect type name for immutable types in error messages

[rdulmina]

Description

function testInvalidReaodOnlyRecordUpdates() {
    Student & readonly b = {};
    b["details"] = 3;
}

public type Student record {|
    int details = 5;
|};

public type ReadOnlyStudent readonly & Student;

Gives cannot update 'readonly' value of type 'ReadOnlyStudent' ideally it should give cannot update 'readonly' value of type '(Student & readonly)'. This is because we maintain symTable.immutableTypeMaps. Need to revisit this

Steps to Reproduce

No response

Affected Version(s)

No response

OS, DB, other environment details and versions

No response

Related area

-> Compilation

Related issue(s) (optional)

No response

Suggested label(s) (optional)

No response

Suggested assignee(s) (optional)

No response

[pcnfernando]

This should be fixed once we remove the workaround we used earlier in https://github.com/ballerina-platform/ballerina-lang/blob/master/compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/SymbolEnter.java#L1748

Hence, assigning @rdulmina

[github-actions]

This issue is NOT closed with a proper Reason/ label. Make sure to add proper reason label before closing. Please add or leave a comment with the proper reason label now.

      - Reason/EngineeringMistake - The issue occurred due to a mistake made in the past.
      - Reason/Regression - The issue has introduced a regression.
      - Reason/MultipleComponentInteraction - Issue occured due to interactions in multiple components.
      - Reason/Complex - Issue occurred due to complex scenario.
      - Reason/Invalid - Issue is invalid.
      - Reason/Other - None of the above cases.