[Compiler] Trap node not identified in module level

[gayalkuruppu]

[Updated]

In module level, the expression keywords such as trap, check, and checkpanic are identified as the ModulePartNode. related: #33833

Consider the following scenario:

Even though the code line with trap is not correct syntactically, we provide completions here and then give code actions to create a variable afterwards. Which makes the code line syntactically correct. This approach is used to improve the user experience and guide/ help the user to write code easily/correct even though started with an incorrect line.

Screen.Recording.2021-11-26.at.09.58.38.mov

But in the module part, for expression related keywords we do not get completions due to this limitation of parser. So our UX end up like this in the module level.

It will be good if we can give the same UX in the module level as well. So can we fix this in order to identify these nodes as their respective matching nodes instead of ModulePartNode?

@nadeeshaan @lochana-chathura @rdulmina

[lochana-chathura]

@gayalkuruppu Can you provide a code sample?

[gayalkuruppu]

@lochana-chathura please refer to this case #33833

[lochana-chathura]

At the module-level parser can't identify expressions without their lhs assignment.
e.g.

var myvar = trap <cursor> // can identify
trap <cursor> // cannot identify

For the second case, it is the same reason as this issue #27268.

[nadeeshaan]

In order to add some more context to this,

At the block node level, we can identify the particular expression, since we support expression statement as per the grammar and in the sense, in the parser. But at the top level, we don't do this and hence we cannot identify the valid context.