BallerinaMethodSymbol and BallerinaSymbol

[dulajdilshan]

Is there any reason why we don't inherit io.ballerina.compiler.api.impl.symbols.BallerinaMethodSymbol from io.ballerina.compiler.api.impl.symbols.BallerinaSymbol?

Ref:

ballerina-lang/compiler/ballerina-lang/src/main/java/io/ballerina/compiler/api/impl/symbols/BallerinaMethodSymbol.java

Line 42 in 21d191b

public class BallerinaMethodSymbol implements MethodSymbol {

The reference issues for this are: #28388 #29467

This happens in the BallerinaSemanticModel when we get the internal symbols, we have to go through this

ballerina-lang/compiler/ballerina-lang/src/main/java/io/ballerina/compiler/api/impl/BallerinaSemanticModel.java

Line 337 in df065ef

return ((BallerinaSymbol) symbol).getInternalSymbol();

The code snippet:

    private BSymbol getInternalSymbol(Symbol symbol) {
        if (symbol.kind() == TYPE) {
            return ((AbstractTypeSymbol) symbol).getBType().tsymbol;
        }

        return ((BallerinaSymbol) symbol).getInternalSymbol();
    }

Here, the error comes because BallerinaMethodSymbol is not inherited BallerinaSymbol' class.

@pubudu91 any thoughts?

[pubudu91]

Didn't extend from BallerinaSymbol at that time because there wasn't any particular reason to do so. The method symbol is basically a wrapper around a function symbol. We just simply call the function symbol's methods for each of the methods. This is for that NPE issue when looking up references of methods in classes right? No harm in extending from BallerinaSymbol. Since these are internal implementation details, we can change these as we see fit.

[dulajdilshan]

@pubudu91 Thanks. Yes, its referenced issues are updated in the discussion description. This is the change I have done: PR #29788. Please have a look and suggest any changes if I need to do