-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Progress #1
Comments
Changes done to block_example as per backdrop-ops/contrib#58 (comment). See branch. No tests yet. |
@cellear or @jenlampton when you get a chance, please have a look at the Backdropification of block_example (both the initial port and the branch with some proposed changes ) and action_example. These two needed drastic changes (blocks are very different in BD, and there is no Trigger module). The Examples were kind of integrated into the API site in Drupal as official examples and we still have references to them in BD API in a few places too; I think it would be great if you guys could give me a review before people start thinking that my port is also official. And if they are up to scratch can you gimme a thought on how (and if) to start config_example Thanks. |
@quicksketch @jenlampton
Thanks |
I've done a little bit of review on the Blocks example. I'll take a look at action_example next.
Responsive tables are super simple, but I think they'd be a good candidate for an example as well. In order to make a table responsive, the only thing you need to do is add classes to header cells. Two classes are supported:
Hoo boy. This could go on for a while. A views example should probably provide:
That's going to be a ton of work. 9/10 times though, the only thing people need to do is expose a table to Views. Most of the time, they don't even need to write any custom handlers, they can just use the handlers provided by Views (e.g.
Config examples are a little hard to provide without a use-case. There are two general ways of exposing config:
Both of these have examples in our current hook_config_info() documentation. It'd be trivial to do a simple config file + a config form. But doing the multiple instances example will need a sample that makes sense and a UI for adding/deleting instances. Besides the basics of config, we could really use more explicit documentation on the |
Thanks again |
I've updated all examples and tests to 1.7.0 compatibility. Added a few more potential examples to the checklist above. Anyone feel like writing new examples for these, feel free to have a go. |
We need a |
@docwilmot I can, but not in the next 15-20 days. |
Meaning ported, tests passing
New core modules
config_exampleuuid_exampleblock_example is a direct port, but will need some changes since Layout changes some of Block's workings.
The text was updated successfully, but these errors were encountered: