Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(crds): add printer columns for Topic and Subscription #63

Merged
merged 2 commits into from
Oct 24, 2024
Merged

feat(crds): add printer columns for Topic and Subscription #63

merged 2 commits into from
Oct 24, 2024

Conversation

a-hilaly
Copy link
Member

Fixes aws-controllers-k8s/community#2194

Adds additional printer columns (ARN, Age, Synced) to Topic and Subscription
CRDs to improve kubectl output. Topics also show DisplayName.

Output example:

k get topics
NAME        DISPLAYNAME   SYNCED   AGE
topic-123   My Topic      True     32m

k get subscriptions -owide
NAME               ARN                                                                                 SYNCED   AGE
subscription-123   arn:aws:sns:us-west-2:095708837592:topic-123:a140e042-4de4-44c3-b301-599672805647   True     25m

k get subscriptions
NAME               SYNCED   AGE
subscription-123   True     25m

k get subscriptions -owide
NAME               ARN                                                                                 SYNCED   AGE
subscription-123   arn:aws:sns:us-west-2:095708837592:topic-123:a140e042-4de4-44c3-b301-599672805647   True     25m

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@a-hilaly
feat(crds): add printer columns for Topic and Subscription
28aa22c 
Adds additional printer columns (ARN, Age, Synced) to Topic and Subscription
CRDs to improve kubectl output. Topics also show DisplayName.
@ack-prow ack-prow bot requested a review from jaypipes October 24, 2024 02:13
@ack-prow ack-prow bot added the approved label Oct 24, 2024
michaelhtm
michaelhtm approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2024
@ack-prow ack-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2024
@ack-prow ACK Prow
Copy link

ack-prow bot commented Oct 24, 2024 •
edited
Loading

@a-hilaly: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
sns-verify-attribution b813745 link false /test sns-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@michaelhtm
Copy link
Member

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2024
@ack-prow ACK Prow
Copy link

ack-prow bot commented Oct 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit 6c63feb into aws-controllers-k8s:main Oct 24, 2024
6 of 7 checks passed
@candonov candonov mentioned this pull request Oct 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelhtm michaelhtm michaelhtm approved these changes

@jaypipes jaypipes Awaiting requested review from jaypipes

Assignees

@michaelhtm michaelhtm

Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve visibility of the status of custom resources on Kubernetes to quickly identify failed resources
2 participants
@a-hilaly @michaelhtm