Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add software grabber tone mapping to global HDR toggle #631

Closed
Titanos opened this issue Aug 27, 2023 · 4 comments
Closed

Add software grabber tone mapping to global HDR toggle #631

Titanos opened this issue Aug 27, 2023 · 4 comments

Comments

@Titanos
Copy link

Titanos commented Aug 27, 2023

Feature request

What problem does this feature solve?

It makes it possible to toggle the software grabber HDR tone mapping via Global HDR toggle and JSON API

What does the proposed API look like?

N/A

How should this be implemented in your opinion?

N/A

Are you willing to work on this yourself?

It is most likely beyond my capabilites

@mariokakoulli
Copy link

Can confirm from the logs, even with USB capture disabled, when using the API call for HDR from "HyperHDR's components" and "HDR mode", MFGrabber.cpp is being loaded and updated instead of DXGrabber.cpp

Not a C++ dev but looking through the repo it seems there is a wrapper for the Grabbers that should be handling this, i can't really work out where it is being called from initially but could it be the instance be getting misconfigured as USB, then when the API is being called and the Wrapper tries to handle it it think the USB is active not DX? will look further but not my area of expertise

@mariokakoulli
Copy link

#637

@mariokakoulli
Copy link

found a fix, have created above PR for it

@awawa-dev
Copy link
Owner

Also #691 If the switch is no longer needed and there are no reported problems with automatic HDR detection, I will close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants