Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test timing issues for slow github test runners #64

Open
Charlesworth opened this issue Jul 7, 2020 · 1 comment
Open

Test timing issues for slow github test runners #64

Charlesworth opened this issue Jul 7, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@Charlesworth
Copy link
Contributor

Some of the tests, in particular the eva_locker_test.py tests use sleeps to ensure thing happen within a set time frame. Unfortunately GitHub's free action test runners are slow enough that these tests can fail in a non-deterministic way if the runner is processing the test a bit slowly. As an example the following test run failed due to a timeout: https://github.com/automata-tech/eva_python_sdk/runs/831475589?check_suite_focus=true

To fix this issue either:

  • increase to duration which is allowed for each test action in eva_locker_test.py (quick and easy but not ideal)
  • remove any reliance on sleeps from eva_locker_test.py (this will be a longer task)
@Charlesworth Charlesworth added the bug Something isn't working label Jul 7, 2020
@LouisBrunner
Copy link
Contributor

I think we should be able to mock any time component using libraries like this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants