Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should with_flux_unit also updates uncertainty unit? #1163

Open
pllim opened this issue Aug 27, 2024 · 0 comments
Open

Should with_flux_unit also updates uncertainty unit? #1163

pllim opened this issue Aug 27, 2024 · 0 comments

Comments

@pllim
Copy link
Member

pllim commented Aug 27, 2024

def with_flux_unit(self, unit, equivalencies=None, suppress_conversion=False):

I find that while flux unit is updated, the uncertainty stays as old unit, when I tried to use this method for spacetelescope/jdaviz#3168 . In the end, I did not use this method (also the copy is unnecessary for me too but addressing that is irrelevant here).

Should uncertainty unit also be updated in this method?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant