Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename image in Docker Hub to asciidoctor/asciidoctor #79

Open
mojavelinux opened this issue Oct 25, 2018 · 7 comments
Open

Rename image in Docker Hub to asciidoctor/asciidoctor #79

mojavelinux opened this issue Oct 25, 2018 · 7 comments
Assignees
Labels
chore Chore tasks (CI, automation, etc.)

Comments

@mojavelinux
Copy link
Member

Currently, the image in the Docker register is asciidoctor/docker-asciidoctor. This name is not consistent with how other Docker images are named. Since this is the official Docker image for Asciidoctor, the name should be asciidoctor/asciidoctor. Let's change it.

We might even want to see if we can become an official image, so we get the name "asciidoctor" all by itself (like ruby). But that might be a next step after resolving the topic at hand.

@dduportal
Copy link
Contributor

👍 I'm on it.

About the "official" image, the process on Docker side is quite tedious:

  • No build-args
  • No Multi stage builds

keep in mind that we might keep both asciidoctor/asciidoctor and ascidoctor images

(I'm thinking about the jenkins image which moved to jenkins/jenkins or the amount of work required for us at Containous for the traefik official image...)

@mojavelinux
Copy link
Member Author

Thanks for the insight @dduportal! If it would restrict us too much, then I say we don't want to pursue the official image...at least not now. We could also consider a simpler image for that purpose, as you suggested, if we really want to hold that spot.

@egorse
Copy link

egorse commented Nov 9, 2018

How about to have properly tagged images there too ? ;)

@mojavelinux
Copy link
Member Author

Could you file a separate issue for that?

@tbreuss
Copy link

tbreuss commented Oct 26, 2019

I stumpled upon this issue while looking for the official asciidoctor image on docker registry.

Is there any progress on this? The issue is exactly one year old.

@mojavelinux
Copy link
Member Author

This is rolled up into #54.

@dduportal
Copy link
Contributor

For clarity, the issue #54 will be solved only on the current name.
As soon as the release process will be ok, a new task for renaming the Docker repos and building 2 images (asciidoctor/asciidoctor and asciidoctor/box) will be done then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore tasks (CI, automation, etc.)
Projects
None yet
Development

No branches or pull requests

4 participants