Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to enable ripgrep using an extension setting (disabled by default) #922

Open
ggrossetie opened this issue Oct 31, 2024 · 1 comment
Labels
💬 discussion Disccussion on new features, projects, etc... ✨ enhancement

Comments

@ggrossetie
Copy link
Member

ripgrep can potentially improve performance compared to workspace.findFiles.
However, it has been shown that ripgrep does not behave the same way as findFiles and causes a number of incompatibilities and even performance issues in certain configurations.

Since some users have reported a significant performance improvement using ripgrep, it would be interesting to provide a way to enable this experimental feature. This would also allow us to gather feedback and bug reports in different contexts without forcing users to revert to a previous version in cases where ripgrep does not work as expected.

The setting should clearly state that this feature is experimental and only available on the desktop version.

@ggrossetie ggrossetie added ✨ enhancement 💬 discussion Disccussion on new features, projects, etc... labels Oct 31, 2024
@alaindresse
Copy link
Contributor

@ggrossetie found some time this weekend to add configuration for ripgrep. Hope this helps !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💬 discussion Disccussion on new features, projects, etc... ✨ enhancement
Projects
None yet
Development

No branches or pull requests

2 participants