-
Notifications
You must be signed in to change notification settings - Fork 499
/
.rubocop.yml
609 lines (609 loc) · 15.2 KB
/
.rubocop.yml
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
require:
- rubocop-rake
- rubocop-rspec
- ./cops/to_pdf_no_debug.rb
AllCops:
TargetRubyVersion: 2.7
Capybara:
Enabled: false
FactoryBot:
Enabled: false
Gemspec/DeprecatedAttributeAssignment:
Enabled: true
Gemspec/DevelopmentDependencies:
Enabled: true
Gemspec/RequireMFA:
Enabled: false
Layout/ArgumentAlignment:
EnforcedStyle: with_fixed_indentation
Layout/BeginEndAlignment:
Enabled: true
Layout/CaseIndentation:
EnforcedStyle: end
Layout/EndOfLine:
EnforcedStyle: lf
Layout/EmptyLineAfterGuardClause:
Enabled: false # reason: unnecessary extra space
Layout/EmptyLinesAroundAttributeAccessor:
Enabled: true
Layout/FirstArgumentIndentation:
Enabled: true
Layout/HashAlignment:
Enabled: true
Layout/HeredocIndentation:
Enabled: false # reason: makes it harder to understand what indentation is significant
Layout/IndentationWidth:
Enabled: true
Layout/LeadingCommentSpace:
Enabled: false # reason: this is just nitpicky
Layout/LineContinuationLeadingSpace:
Enabled: true
Layout/LineContinuationSpacing:
Enabled: true
Layout/LineEndStringConcatenationIndentation:
Enabled: true
Layout/LineLength:
Enabled: false # FIXME enable me
Layout/MultilineMethodCallIndentation:
EnforcedStyle: indented
Layout/MultilineOperationIndentation:
EnforcedStyle: indented
Layout/ParameterAlignment:
EnforcedStyle: with_fixed_indentation
IndentationWidth: 4
Layout/RescueEnsureAlignment:
Enabled: true
Layout/SpaceAroundMethodCallOperator:
Enabled: true
Layout/SpaceAroundOperators:
Enabled: true
EnforcedStyleForExponentOperator: space
Layout/SpaceBeforeBrackets:
Enabled: true
Layout/SpaceInsideBlockBraces:
SpaceBeforeBlockParameters: false
Lint/AmbiguousAssignment:
Enabled: true
Lint/AmbiguousBlockAssociation:
Enabled: true # NOTE this is pedantic when using braces for single-line blocks
Exclude: [ spec/*.rb ]
Lint/AmbiguousOperatorPrecedence:
Enabled: false
Lint/AmbiguousRange:
Enabled: true
Lint/BinaryOperatorWithIdenticalOperands:
Enabled: true
Lint/ConstantDefinitionInBlock:
Enabled: true
Exclude: [ spec/*.rb ]
Lint/ConstantOverwrittenInRescue:
Enabled: true
Lint/DeprecatedConstants:
Enabled: true
Lint/DeprecatedOpenSSLConstant:
Enabled: true
Lint/DuplicateBranch:
Enabled: true
Lint/DuplicateElsifCondition:
Enabled: true
Lint/DuplicateMagicComment:
Enabled: true
Lint/DuplicateMatchPattern:
Enabled: true
Lint/DuplicateRegexpCharacterClassElement:
Enabled: true
Lint/DuplicateRequire:
Enabled: true
Lint/DuplicateRescueException:
Enabled: true
Lint/EmptyBlock:
Enabled: true
Lint/EmptyClass:
Enabled: true
Lint/EmptyConditionalBody:
Enabled: true
Lint/EmptyFile:
Enabled: true
Lint/EmptyInPattern:
Enabled: true
Lint/EmptyWhen:
Enabled: false # reason: an empty when can be important for excluding matches
Lint/FloatComparison:
Enabled: true
Exclude: [ spec/*.rb ]
Lint/IdentityComparison:
Enabled: true
Lint/IncompatibleIoSelectWithFiberScheduler:
Enabled: true
Lint/ItWithoutArgumentsInBlock:
Enabled: true
Lint/LambdaWithoutLiteralBlock:
Enabled: true
Lint/LiteralAssignmentInCondition:
Enabled: false # reason: we know what we're doing; sometimes it's necessary to assign a literal value
Lint/MissingSuper:
Enabled: false # FIXME consider enabling
Lint/MixedCaseRange:
Enabled: true
Lint/MixedRegexpCaptureTypes:
Enabled: true
Lint/NoReturnInBeginEndBlocks:
Enabled: true
Lint/NonAtomicFileOperation:
Enabled: false
Lint/NumberedParameterAssignment:
Enabled: true
Lint/OrAssignmentToConstant:
Enabled: true
Lint/OutOfRangeRegexpRef:
Enabled: true
Lint/ParenthesesAsGroupedExpression:
Enabled: false # reason: we prefer to enclose assignments
Lint/RaiseException:
Enabled: true
Lint/RedundantDirGlobSort:
Enabled: true
Lint/RedundantRegexpQuantifiers:
Enabled: true
Lint/RefinementImportMethods:
Enabled: true
Lint/RequireRangeParentheses:
Enabled: true
Lint/RequireRelativeSelfPath:
Enabled: true
Lint/SelfAssignment:
Enabled: true
Lint/StructNewOverride:
Enabled: true
Lint/SuppressedException:
Enabled: true
Lint/SymbolConversion:
Enabled: false # reason: requires use of :"static#{variable}" which is not the style we prefer
Lint/ToEnumArguments:
Enabled: true
Lint/TopLevelReturnWithArgument:
Enabled: true
Lint/TrailingCommaInAttributeDeclaration:
Enabled: true
Lint/TripleQuotes:
Enabled: true
Lint/UnexpectedBlockArity:
Enabled: true
Lint/UnmodifiedReduceAccumulator:
Enabled: true
Lint/UnreachableLoop:
Enabled: true
Lint/UnusedMethodArgument:
Enabled: true
Lint/UselessMethodDefinition:
Enabled: true
Lint/UselessRescue:
Enabled: true
Lint/UselessRuby2Keywords:
Enabled: true
Lint/UselessTimes:
Enabled: true
Metrics/AbcSize:
Enabled: false
Metrics/BlockLength:
Enabled: false
Metrics/BlockNesting:
Max: 10
Metrics/ClassLength:
Enabled: false
Metrics/CollectionLiteralLength:
Enabled: true
Metrics/CyclomaticComplexity:
Enabled: false
Metrics/MethodLength:
Enabled: false
Metrics/ModuleLength:
Enabled: false
Metrics/ParameterLists:
Max: 10
MaxOptionalParameters: 10
Metrics/PerceivedComplexity:
Enabled: false
Naming/AccessorMethodName:
Enabled: false # reason: needed to override built-in method names
Naming/BlockForwarding:
Enabled: true
Naming/ConstantName:
Enabled: false # FIXME consider reenabling
Naming/FileName:
Enabled: false # reason: needed to conform to Prawn ecosystem
Naming/HeredocDelimiterNaming:
Enabled: true
ForbiddenDelimiters:
- !ruby/regexp '/^\s*EO[A-Z]\s*$/'
Naming/InclusiveLanguage:
Enabled: true
Naming/MethodParameterName:
Enabled: false # reason: needed to conform to Prawn ecosystem
Naming/PredicateName:
Enabled: true
Naming/VariableNumber:
Enabled: false # reason: this is just nitpicky
RSpec/BeEmpty:
Enabled: true
RSpec/BeEq:
Enabled: true
RSpec/BeEql:
Enabled: false # reason: can lead to cryptic error messages when comparing integers
RSpec/BeNil:
Enabled: true
RSpec/BeforeAfterAll:
Enabled: true
RSpec/ContainExactly:
Enabled: true
RSpec/ChangeByZero:
Enabled: true
RSpec/ClassCheck:
Enabled: true
RSpec/ContextWording:
Enabled: false
RSpec/DescribeClass:
Enabled: false
RSpec/DuplicatedMetadata:
Enabled: true
RSpec/EmptyExampleGroup:
Enabled: true
RSpec/EmptyMetadata:
Enabled: true
RSpec/Eq:
Enabled: true
RSpec/ExampleLength:
Enabled: false
RSpec/ExampleWording:
Enabled: false
RSpec/ExcessiveDocstringSpacing:
Enabled: true
RSpec/ExpectInHook:
Enabled: true
RSpec/FactoryBot:
Enabled: false
RSpec/FilePath:
Enabled: false
RSpec/IdenticalEqualityAssertion:
Enabled: true
RSpec/IndexedLet:
Enabled: true
RSpec/IsExpectedSpecify:
Enabled: true
RSpec/MatchArray:
Enabled: true
RSpec/MetadataStyle:
Enabled: false # reason: this rule is just confused
EnforcedStyle: symbol
RSpec/MultipleExpectations:
Enabled: true
Max: 25 # FIXME get this down to 15
RSpec/NamedSubject:
Enabled: false
RSpec/NoExpectationExample:
Enabled: false
RSpec/Pending:
Enabled: false # reason: incorrectly detects spec as proc as pending
RSpec/PendingWithoutReason:
Enabled: true
RSpec/Rails:
Enabled: false
RSpec/ReceiveMessages:
Enabled: true
RSpec/RedundantAround:
Enabled: true
RSpec/RedundantPredicateMatcher:
Enabled: true
RSpec/RemoveConst:
Enabled: false # reason: we need this capability
RSpec/RepeatedSubjectCall:
Enabled: true
RSpec/SkipBlockInsideExample:
Enabled: true
RSpec/SortMetadata:
Enabled: true
RSpec/SpecFilePathFormat:
Enabled: false # reason: we prefer to name spec files the way we want to name them
RSpec/SpecFilePathSuffix:
Enabled: true
RSpec/SubjectDeclaration:
Enabled: true
RSpec/VerifiedDoubleReference:
Enabled: true
RSpec/VoidExpect:
Enabled: false
Security/CompoundHash:
Enabled: true
Security/IoMethods:
Enabled: true
Security/Open:
Enabled: true
Style/AccessorGrouping:
Enabled: true
EnforcedStyle: separated
Style/Alias:
Enabled: true
EnforcedStyle: prefer_alias
Style/ArgumentsForwarding:
Enabled: true
Style/ArrayCoercion:
Enabled: false # reason: using [*values] is faster
Style/ArrayIntersect:
Enabled: true
Style/AsciiComments:
Enabled: false # reason: this is just nitpicky
Style/Attr:
Enabled: false # reason: gets confused by Asciidoctor's attr method
Style/BisectedAttrAccessor:
Enabled: true
Style/BlockComments:
Enabled: true
Style/BlockDelimiters:
EnforcedStyle: line_count_based # FIXME we want this to be line_count_based except when chaining
Style/CaseEquality:
Enabled: false # reason: === is a useful operator
Style/CaseLikeIf:
Enabled: true
Style/CharacterLiteral:
Enabled: false # reason: ? can make single characters easier to type
Style/ClassAndModuleChildren:
Enabled: false # reason: both forms are useful
Style/ClassVars:
Enabled: false # reason: an important language feature
Style/CollectionCompact:
Enabled: true
Style/CombinableLoops:
Enabled: true
Style/CommandLiteral:
EnforcedStyle: percent_x
Style/CommentAnnotation:
Enabled: true
Keywords:
- TODO
- FIXME
- HACK
- NOTE
- QUESTION
RequireColon: true
Style/ComparableClamp:
Enabled: true
Style/ConcatArrayLiterals:
Enabled: true
Style/ConditionalAssignment:
EnforcedStyle: assign_inside_condition
IncludeTernaryExpressions: false
Style/DataInheritance:
Enabled: true
Style/DirEmpty:
Enabled: true
Style/DocumentDynamicEvalDefinition:
Enabled: true
Style/Documentation:
Enabled: false # FIXME reenable
Style/DoubleNegation:
Enabled: true
Style/EmptyHeredoc:
Enabled: true
Style/EmptyLiteral:
Enabled: true
Style/EndlessMethod:
Enabled: true
Style/EnvHome:
Enabled: true
Style/ExactRegexpMatch:
Enabled: true
Style/ExplicitBlockArgument:
Enabled: false # reason: yield is fine
Style/ExponentialNotation:
Enabled: true
Style/FetchEnvVar:
Enabled: false # reason: just no
Style/FileEmpty:
Enabled: true
Style/FileRead:
Enabled: true
Style/FileWrite:
Enabled: true
Style/FormatString:
EnforcedStyle: sprintf
Style/FormatStringToken:
Enabled: true
EnforcedStyle: unannotated
Style/GlobalStdStream:
Enabled: true
Style/GuardClause:
Enabled: true
MinBodyLength: 15
Style/HashConversion:
Enabled: true
Style/HashAsLastArrayItem:
Enabled: true
EnforcedStyle: no_braces
Style/HashEachMethods:
Enabled: true
Style/HashExcept:
Enabled: true
Style/HashLikeCase:
Enabled: true
Style/HashSyntax:
EnforcedStyle: ruby19
Style/HashTransformKeys:
Enabled: true
Style/HashTransformValues:
Enabled: true
Style/IfWithBooleanLiteralBranches:
Enabled: true
AllowedMethods:
- empty?
- nil_or_empty?
Style/IfUnlessModifier:
Enabled: false # reason: this gets crazy
Style/IfUnlessModifierOfIfUnless:
Enabled: false # reason: we prefer this style to avoid extra nesting
Style/InPatternThen:
Enabled: true
Style/InfiniteLoop:
Enabled: false # reason: loop is measurably slower than while true
Style/KeywordParametersOrder:
Enabled: true
Style/MagicCommentFormat:
Enabled: true
Style/MapCompactWithConditionalBlock:
Enabled: true
Style/MapToHash:
Enabled: false # reason: not supported in JRuby < 9.3
Style/MapToSet:
Enabled: false # reason: not supported in JRuby < 9.3
Style/MethodCallWithArgsParentheses:
Enabled: true
EnforcedStyle: omit_parentheses
Style/MethodDefParentheses:
EnforcedStyle: require_no_parentheses
Style/MinMaxComparison:
Enabled: true
Style/MultilineBlockChain:
Enabled: false # reason: no reason not to allow method call on block result
Style/MultilineInPatternThen:
Enabled: true
Style/MultilineIfModifier:
Enabled: false # reason: we prefer this style to avoid extra nesting
Style/MultilineTernaryOperator:
Enabled: false # reason: a ternary is a ternary
Style/MultipleComparison:
Enabled: false # reason: faster than the alternative of using Array#include?
Style/MutableConstant:
Enabled: false # reason: freezing constants is pendantic
Style/NegatedIfElseCondition:
Enabled: true
Style/NestedFileDirname:
Enabled: true
Style/NestedParenthesizedCalls:
Enabled: true
Style/NestedTernaryOperator:
Enabled: false # reason: a ternary is a ternary
Style/NilLambda:
Enabled: true
Style/NumberedParameters:
Enabled: true
Style/NumberedParametersLimit:
Enabled: true
Style/NumericLiterals:
Enabled: false # reason: makes large numbers unreadable and harder to copy
Style/NumericPredicate:
EnforcedStyle: comparison
Style/ObjectThen:
Enabled: false # reason: not yet available in minimum JRuby version
Style/OpenStructUse:
Enabled: false # reason: the theming system relies on OpenStruct
Style/OperatorMethodCall:
Enabled: true
Style/OptionalBooleanParameter:
Enabled: false # reason: invasive
Style/ParallelAssignment:
Enabled: false # reason: an important language feature
Style/PercentLiteralDelimiters:
PreferredDelimiters:
default: "()"
"%i": "()"
"%r": "//"
"%w": "()"
"%W": "()"
Style/PerlBackrefs:
Enabled: false # reason: an important language feature
Style/QuotedSymbols:
Enabled: true
Style/RedundantArgument:
Enabled: true
Style/RedundantArrayConstructor:
Enabled: true
Style/RedundantAssignment:
Enabled: true
Style/RedundantBegin:
Enabled: true
Style/RedundantConstantBase:
Enabled: true
Style/RedundantCurrentDirectoryInPath:
Enabled: true
Style/RedundantDoubleSplatHashBraces:
Enabled: true
Style/RedundantEach:
Enabled: true
Style/RedundantFetchBlock:
Enabled: true
Style/RedundantFileExtensionInRequire:
Enabled: true
Style/RedundantFilterChain:
Enabled: true
Style/RedundantHeredocDelimiterQuotes:
Enabled: false # reason: we know what we are doing
Style/RedundantInitialize:
Enabled: true
Style/RedundantLineContinuation:
Enabled: true
Style/RedundantParentheses:
Enabled: false # reason: sometimes the parentheses just make it clearer; this rule is too aggressive
Style/RedundantPercentQ:
Enabled: true
Style/RedundantRegexpArgument:
Enabled: true
Style/RedundantRegexpCharacterClass:
Enabled: true
Style/RedundantRegexpConstructor:
Enabled: true
Style/RedundantRegexpEscape:
Enabled: true
Style/ReturnNilInPredicateMethodDefinition:
Enabled: true
Style/RedundantSelfAssignment:
Enabled: true
Style/RedundantSelfAssignmentBranch:
Enabled: false
Style/SingleLineDoEndBlock:
Enabled: true
Style/RedundantStringEscape:
Enabled: false # reason: this rule crashes RuboCop
Style/RegexpLiteral:
Enabled: true
Style/RescueModifier:
Enabled: false # reason: a useful language feature
Style/RescueStandardError:
EnforcedStyle: implicit
Style/MissingRespondToMissing:
Enabled: true
Style/SafeNavigation:
Enabled: true
Style/SelectByRegexp:
Enabled: true
Style/SingleArgumentDig:
Enabled: true
Style/SlicingWithRange:
Enabled: false # reason: not supported in JRuby < 9.3
Style/SoleNestedConditional:
Enabled: true
Style/SpecialGlobalVars:
EnforcedStyle: use_perl_names
Style/StderrPuts:
Enabled: true
Style/StringChars:
Enabled: true
Style/StringConcatenation:
Enabled: false # reason: string concatenation can be faster
Style/SuperWithArgsParentheses:
Enabled: false # reason: hate it
Style/SwapValues:
Enabled: true
Style/SymbolArray:
EnforcedStyle: brackets
Style/SymbolProc:
Enabled: true
Style/TernaryParentheses:
Enabled: false # reason: this rule has become too buggy and gets it wrong most of the time
EnforcedStyle: require_parentheses_when_complex
Style/TrailingCommaInArrayLiteral:
EnforcedStyleForMultiline: consistent_comma
Style/TrailingCommaInHashLiteral:
EnforcedStyleForMultiline: consistent_comma
Style/WordArray:
Enabled: true
Style/YAMLFileRead:
Enabled: true