Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No error for missing image in a different Antora module #1727

Closed
Grolribasi opened this issue Oct 30, 2024 · 1 comment
Closed

No error for missing image in a different Antora module #1727

Grolribasi opened this issue Oct 30, 2024 · 1 comment
Labels

Comments

@Grolribasi
Copy link
Contributor

Observed vs. expected behavior

When referring to a nonexistent image, there is usually an error. That's correct.
But when referring to a nonexistent image in a different module, there is no error. That's not correct, there should be an error.

Steps to reproduce

  1. Create Antora component structure with at least two module folders. For example, module 1: "admin" and module 2: "user".
  2. On a page from a module refer to a nonexistent image from the second module For example, in module "user" refer to an image from module "admin" like so: image::admin:install.png[].
  3. The image is not displayed in the preview area because it doesn't exist, but there is no error report "file doesn't resolve" for a missing image, you won't know the image is missing before you build the site.

Environment

Plugin Version: 43.2

IntelliJ Details: 2024.2.4 Community

@Grolribasi Grolribasi added the bug label Oct 30, 2024
@ahus1
Copy link
Contributor

ahus1 commented Dec 1, 2024

Thank you for noticing this. I had a look and found that the regex I used identified the body as a URL due to the colon used in there. I update the plugin and the next version will be more restrictive and will recognize the error unless you would name a module data or mailto.

I'll update this issue once a pre-release is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants