Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin includes multiple versions of the same dependency #709

Open
tylerbertrand opened this issue Jan 17, 2024 · 1 comment
Open

Plugin includes multiple versions of the same dependency #709

tylerbertrand opened this issue Jan 17, 2024 · 1 comment
Milestone

Comments

@tylerbertrand
Copy link

The plugin includes multiple versions of the jruby-complete dependency.

This causes conflicts during dependency resolution, and results in failed builds when applied to a build with failOnVersionConflict enabled.

It looks like this code adds the asciidoctorj dependency, then adds jruby-complete with the version provided by minimumSafeJrubyVersion, which is currently set to 9.1.0.0. I believe this should be updated to 9.3.8.0, which is the version used in asciidoctorj:2.5.7.

Tested against plugin version 4.0.1.

@dubinsky
Copy link

dubinsky commented Jun 3, 2024

I am not sure that the pull request #714 is sufficient: with 4.0.2 and

asciidoctorj {
    version = '2.5.13'
    jrubyVersion = '9.4.7.0'
    modules.pdf.version '2.3.15'
}

I see in the Gradle dependencies report multiple versions of dependencies not just for JRuby:

__$$asciidoctorj$$___d (n)
+--- org.asciidoctor:asciidoctorj:2.5.7 (n)
+--- org.jruby:jruby-complete:9.1.0.0 (n)
\--- org.asciidoctor:asciidoctorj-pdf:2.3.10 (n)

__$$asciidoctorj$$___r
+--- org.asciidoctor:asciidoctorj:2.5.7
|    \--- org.jruby:jruby:9.3.8.0 -> org.jruby:jruby-complete:9.3.8.0
+--- org.jruby:jruby-complete:9.1.0.0 -> 9.3.8.0
\--- org.asciidoctor:asciidoctorj-pdf:2.3.10

__$$asciidoctorj_asciidoctor$$__d (n)
+--- org.asciidoctor:asciidoctorj:2.5.7 (n)
+--- org.jruby:jruby-complete:9.1.0.0 (n)
\--- org.asciidoctor:asciidoctorj-pdf:2.3.10 (n)

__$$asciidoctorj_asciidoctor$$__r
+--- org.asciidoctor:asciidoctorj:2.5.7 -> 2.5.13
|    \--- org.jruby:jruby:9.4.7.0 -> org.jruby:jruby-complete:9.4.7.0
+--- org.jruby:jruby-complete:9.1.0.0 -> 9.4.7.0
\--- org.asciidoctor:asciidoctorj-pdf:2.3.10 -> 2.3.15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants