Skip to content
This repository has been archived by the owner on Feb 8, 2021. It is now read-only.

Do not use explicit colours #4

Open
piefel opened this issue Apr 13, 2016 · 2 comments
Open

Do not use explicit colours #4

piefel opened this issue Apr 13, 2016 · 2 comments

Comments

@piefel
Copy link

piefel commented Apr 13, 2016

The syntax file contains a lot of highlight definitions mapping to fixed colours. That’s not how Vim syntax files are supposed to do it.

@elextr
Copy link
Contributor

elextr commented Apr 13, 2016

It would be more useful if you provided some more information, a reference to the method you claim should be used, or better yet a pull request with a fix.

@piefel
Copy link
Author

piefel commented Apr 19, 2016

The correct method is already used for some definitions – linking to predefined groups:

highlight link asciidocCallout Label
highlight link asciidocEntityRef Special

Although, nowadays syntax files seem to do that with hi def link instead. The Vim syntax states which highlighting groups are standard, but this is a very short list. Instead, the standard colour files, such as slate.vim or zellner.vim, define a number of hightlighting groups that are a de-facto standard. Linking to them would be safest.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants