Skip to content
This repository has been archived by the owner on Jan 4, 2023. It is now read-only.

Merge 2 Input Group #505

Open
Peltier10 opened this issue Apr 6, 2021 · 2 comments
Open

Merge 2 Input Group #505

Peltier10 opened this issue Apr 6, 2021 · 2 comments
Labels
enhancement New feature or request Help Wanted Extra attention is needed

Comments

@Peltier10
Copy link

Peltier10 commented Apr 6, 2021

Problem

In Rose usecase : two SQL Input have distinct condition because they have different id in the database.

Description

In Rose mapping, a date/time is required but the date and the time do not have the same id in the database. I need to have a FHIR dateTime attribut with 0...1 occurence.
First solution : to have possibility to merge Input group in Pyrog

Alternatives

Alternative solutions : in an Input group, if more than one condition are filled, possibility to choose between intersection or union. (At the moment, it is an intersection).

@simonvadee simonvadee added the enhancement New feature or request label Apr 6, 2021
@simonvadee
Copy link
Contributor

Thank you for reporting this, I understand the issue and agree that it needs some work to make this possible!

I personally don't think it makes sense to merge several Input groups together: since you need two columns to fill a single attribute, it fits the definition of an "input group" for which you need to merge values together (aka: using a merging script).
Therefore I would vote for implementing unions between conditions. What's your opinion @Jasopaum ?

@simonvadee simonvadee added the Help Wanted Extra attention is needed label Apr 6, 2021
@Jasopaum
Copy link
Contributor

Jasopaum commented Apr 7, 2021

Agreed, the user should be able to "aggregate" conditions with ANDs and ORs 👍
The 2 pain points being : the UI and how to model that

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request Help Wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants