Add workflow to auto-assign incident issues to the Incident project #9
Conversation
LaRiffle
added
the
type/improvement
There was a problem hiding this comment.
This will work only for issues open on this repository, no? I believe this doesn't fix #8, we need to add the same workflow call to all the repos (or perhaps you just want to do that later?)
|
@clementjumel I guess it will work for all because it is in |
|
Or maybe not... See https://docs.github.com/en/actions/using-workflows/creating-starter-workflows-for-your-organization |
I might be wrong but I don't think so!
This is where mono-repos shine 😇 Imo we do have to create a workflow in each repo. For the future, we simply need to make sure that all new repository derives from a template where the workflow is implemented so it should not be too troublesome. In the meantime, adding a starter workflow could be the right way to go, to make the addition of the new files less troublesome! |
|
|
||
| jobs: | ||
| incident-report: | ||
| if: ${{ github.event.label.name == 'type/incident' }} |
There was a problem hiding this comment.
I don't think this will work: what you did was a good solution for a labelling event, ie when you add a label to an issue (like documented here) but you have 2 cases: labelling event or issue (re-)opening, and in the 2nd case this will likely not work (for instance you can have several labels).
We need to
- add a solution like this one in the mix, but then we need to be smart on the if clause
- simplify this to work only on labelling event ; I don't think this will work when an issue is created with a label already, but we never know
|
Will close this one in favor of deployment-template#20 |
Fixes
Fixes #8
Description
Finally I've put the filter on the label directly on the call to reusable workflow
I've also added a trigger at labelling events.
Definition of Done