You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the webrtc reality depends on a square camera image, which Chrome provides on most Android devices. This needs to be fixed to support other platforms.
Suggested steps:
Rework the ARController.getUserMedia function in webrtc.ts. This logic can probably be improved to follow the latest standards, especially with regards to recommended vs. required resolution and choosing the back-facing camera.
Request a non-square camera image when calling ARController.getUserMediaThreeScene (currently we ask for 240x240, perhaps this should be 320x240).
Ensure jsartoolkit is updated with the correct camera resolution if it changes on device rotation. This may require reinitialization?
Double-check that the logic in updateViewport correctly stretches the camera image to aspect-fill the viewport (in both portrait and landscape). This may need to be reworked.
Adjust the projection matrix in updateProjection to account for the portion of the camera image that is currently visible (e.g. adjust the fov). This will change on rotation. Note: this projection only affects augmentations, not the rendering of the camera image. Test by aligning content on a jsartoolkit marker.
The text was updated successfully, but these errors were encountered:
Currently the webrtc reality depends on a square camera image, which Chrome provides on most Android devices. This needs to be fixed to support other platforms.
Suggested steps:
Rework the
ARController.getUserMedia
function in webrtc.ts. This logic can probably be improved to follow the latest standards, especially with regards to recommended vs. required resolution and choosing the back-facing camera.Request a non-square camera image when calling
ARController.getUserMediaThreeScene
(currently we ask for 240x240, perhaps this should be 320x240).Ensure jsartoolkit is updated with the correct camera resolution if it changes on device rotation. This may require reinitialization?
Double-check that the logic in
updateViewport
correctly stretches the camera image to aspect-fill the viewport (in both portrait and landscape). This may need to be reworked.Adjust the projection matrix in
updateProjection
to account for the portion of the camera image that is currently visible (e.g. adjust the fov). This will change on rotation. Note: this projection only affects augmentations, not the rendering of the camera image. Test by aligning content on a jsartoolkit marker.The text was updated successfully, but these errors were encountered: