chore: devnet to testnet #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will continue to add to these function with delegates who elect not to receive rewards.
This will minimize the gateway request. The SDK and downstream apps are already using the newest APIs
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #224 +/- ##
==========================================
- Coverage 95.86% 95.74% -0.12%
==========================================
Files 11 11
Lines 2780 2869 +89
==========================================
+ Hits 2665 2747 +82
- Misses 115 122 +7 ☔ View full report in Codecov by Sentry. |
…quest primary name tag
#226) …quest primary name tag Related: ar-io/ar-io-sdk#281
when not providing Years on Token-Cost of type 'lease' we see `]:6860:
attempt to perform arithmetic on a nil value (local 'years')`:
```sh
{"level":"debug","message":"Evaluating read interaction on contract","name":"ar-io-sdk","tags":[{"name":"Action","value":"Token-Cost"},{"name":"Intent","value":"Buy-Record"},{"name":"Name","value":"my-name"},{"name":"Timestamp","value":"1732562026000"}],"timestamp":"2024-11-25T19:19:02.641Z","version":"2.5.0-alpha.13"}
{"level":"debug","message":"Read interaction result","name":"ar-io-sdk","result":{"Assignments":[],"GasUsed":2691395618,"Messages":[{"Anchor":"00000000000000000000000000002902","Data":"[string \"aos\"]:6860: attempt to perform arithmetic on a nil value (local 'years')","Tags":[{"name":"Data-Protocol","value":"ao"},{"name":"Variant","value":"ao.TN.1"},{"name":"Type","value":"Message"},{"name":"Reference","value":"2902"},{"name":"Action","value":"Invalid-Token-Cost-Notice"},{"name":"X-Origin","value":""},{"name":"X-Reference","value":""},{"name":"Error","value":"[string \"aos\"]:6860: attempt to perform arithmetic on a nil value (local 'years')"}],"Target":"1234"}],"Output":{"data":"Pruning state at timestamp: 1732562026000\n{\"Type\":\"Message\",\"Timestamp\":\"1732562026000\",\"Variant\":\"ao.TN.1\",\"Intent\":\"Buy-Record\",\"Cast\":false,\"Cron\":false,\"From\":\"1234\",\"Action\":\"Token-Cost\",\"Pruned-Requests-Count\":0,\"_e\":1,\"Name\":\"my-name\",\"From-Formatted\":\"1234\",\"Epoch-Index\":153,\"Data-Protocol\":\"ao\",\"Message-Id\":\"1234\"}\n{\"Type\":\"Message\",\"Error\":\"[string \\\"aos\\\"]:6860: attempt to perform arithmetic on a nil value (local 'years')\",\"Timestamp\":\"1732562026000\",\"Variant\":\"ao.TN.1\",\"Intent\":\"Buy-Record\",\"Cast\":false,\"Cron\":false,\"From\":\"1234\",\"Action\":\"Token-Cost\",\"Pruned-Requests-Count\":0,\"_e\":1,\"Name\":\"my-name\",\"From-Formatted\":\"1234\",\"Epoch-Index\":153,\"Data-Protocol\":\"ao\",\"Message-Id\":\"1234\"}","print":true,"prompt":"\u001b[32mDevnet IO\u001b[90m@\u001b[34maos-2.0.1\u001b[90m[Inbox:\u001b[31m265\u001b[90m]\u001b[0m> "},"Spawns":[]},"timestamp":"2024-11-25T19:19:03.384Z","version":"2.5.0-alpha.13"}
{"error":{},"level":"debug","message":"Read attempt 3 failed","name":"ar-io-sdk","tags":[{"name":"Action","value":"Token-Cost"},{"name":"Intent","value":"Buy-Record"},{"name":"Name","value":"my-name"},{"name":"Timestamp","value":"1732562026000"}],"timestamp":"2024-11-25T19:19:03.384Z","version":"2.5.0-alpha.13"}
[string "aos"]:6860: attempt to perform arithmetic on a nil value (local 'years'): [string "aos"]:6860: attempt to perform arithmetic on a nil value (local 'years')
```
This one is a little different than the others because there's a very structured way in which the epochs are created and pruned. There's no need to reset the next prune timestamp after user actions here. Note: I modified the deepCopy behavior to: - do a very fast, basic deep copy if no exclusions are present - if exclusions are present, activate the reindexing feature for numeric Arrays (not dictionaries)
arielmelendez
temporarily deployed
to
develop
GitHub Actions
Inactive
Moves the gar functions to helpers.mjs, and updates tests with new values Includes PE-7186/PE-7187/PE-7188
Moves the gar functions to helpers.mjs, and updates tests with new values Includes PE-7186/PE-7187/PE-7188
…xisting owner (#230) Allows a user to replace an existing primary name request with a new one, so long as it is a different name
arielmelendez
temporarily deployed
to
develop
GitHub Actions
Inactive
arielmelendez
temporarily deployed
to
develop
GitHub Actions
Inactive
arielmelendez
temporarily deployed
to
develop
GitHub Actions
Inactive
arielmelendez
approved these changes
Nov 27, 2024
fedellen
reviewed
Nov 27, 2024
Comment on lines
+306
to
+307
| { name: 'Quantity', value: `${quantity}` }, // 2K IO | ||
| { name: 'Address', value: gatewayAddress }, // our gateway address |
fedellen
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes:
Force-Prunetag to prune state forcefully vs. optimsitically