Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Updated ui in topdeals.html #1599

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Nelathecoder
Copy link

@Nelathecoder Nelathecoder commented Oct 30, 2024

changed the background and the alignment of card contents

Title and Issue number

Title : UI can be improved

Issue No. : 1412

Code Stack : html, css

Close #1412

Description

changed the background of the top deals page and changed the alignment of card content.

Video/Screenshots (mandatory)

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing
  • I have Starred the Repository.

Additional context:

##Are you contributing under any Open-source programme?

  • I am contributing under GSSOC'24 Extended

changed the background and the alignment of card contents
Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit 3d94c55
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/6722157da919b2000805e463
😎 Deploy Preview https://deploy-preview-1599--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Nelathecoder Nelathecoder reopened this Oct 30, 2024
@apu52 apu52 changed the title Updated ui in topdeals.html feat: Updated ui in topdeals.html Oct 31, 2024
@@ -14,7 +14,7 @@

body {
font-family: Arial, sans-serif;
background:url("bestdeals.jpg");
background:url("topdeals_bg.jpg");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

u have added some bg , but there is only a white bg its showing that , & there is alo an unusual blank space on the top of the page

@apu52 apu52 added the help wanted Extra attention is needed label Oct 31, 2024
@apu52 apu52 mentioned this pull request Nov 16, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: UI can be improved
2 participants