Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Update openjscad code to follow the new jscad organization layout #9

Open
faithhack opened this issue Jun 15, 2017 · 6 comments

Comments

@faithhack
Copy link

faithhack commented Jun 15, 2017

Is there plans to update the included openjscad code to track all the reorganization work done at https://github.com/jscad ? It would be helpful since all of the newer work for SVG, fonts, 3d hulls, etc. will land there and I would like to use them in Atom.

@matiasinsaurralde
Copy link
Collaborator

Looks wonderful!

@apla
Copy link
Owner

apla commented Jun 15, 2017 via email

@matiasinsaurralde
Copy link
Collaborator

@apla Great, if you create issues for the tasks I would be happy to continue the collaboration.

Best!

@kaosat-dev
Copy link

@apla do you need any help with this ? I would gladly chip in if needed :) (would love to use this more in Atom, (current version already rocks though!)

@apla
Copy link
Owner

apla commented Oct 19, 2017

Hi, @kaosat-dev and everyone. Unfortunately, this summer I've lost my progress on some open source projects because of simultaneous fail of my notebook ssd and backup storage (seems like i'm going for geo-distributed backups).

To move forward with this plugin, we need to make few changes:

  1. Backport: integrate changes from plugin back to the scad core. Mainly those changes affects error handling and I've spend quite a lot time to get almost proper error location in the source code for most errors.
  2. Rendering backend: atom plugin using three.js and maybe there some changes which is incompatible with current jscad.
  3. Tests: set up tests to make sure plugin works properly. Unfortunately, I'm not sure how to make it. Especially rendering.
  4. Docs: I've spent some time to extract completions from the docs, need to look again into that code.

@kaosat-dev
Copy link

hi @apla !
That is really a bummer !

  1. that would be interesting ! I honestly never really looked into that area but it is very useful.
  2. ever since the restructuring , most things (ie all except the default openjscad ui) are rendering system agnostic : personally I use a regl based renderer , and future versions of official jscad UI will likely do so as well, but pretty much everything should work exactly the same regardless of renderer . I also used to be a big fan of three.js so I can understand that choice too.
  3. Not sure what you mean by test ? you mean expected visual results based on an input jscad script ? I have a lot of experience and tooling for unit tests that work on such a basis for webgl projects so I might be able to help.
  4. ok , sounds good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants