This repository has been archived by the owner on Jul 9, 2024. It is now read-only.
449 update single beacon without multicall #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acenolaza
force-pushed
the
449-update-single-beacon-without-multicall
branch
from
1b52893
to
e1aa4af
Compare
bdrhn9
approved these changes
Sep 17, 2023
| () => | ||
| contract | ||
| .connect(voidSigner) | ||
| .callStatic.tryMulticall(readBatch.map((beaconUpdate) => beaconUpdate.dataFeedsCalldata)), |
There was a problem hiding this comment.
It's nit. However it'd be better to not to use multicall while reading if batch only includes 1 beacon. To merge this PR quick, I created the issue #475.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #449