Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with PyJWT 2.10: Subject must be a string #30995

Open
3 tasks done
amotl opened this issue Nov 20, 2024 · 3 comments
Open
3 tasks done

Problem with PyJWT 2.10: Subject must be a string #30995

amotl opened this issue Nov 20, 2024 · 3 comments

Comments

@amotl
Copy link
Contributor

amotl commented Nov 20, 2024

Bug description

When setting up a fresh sandbox environment, PyJWT 2.10 gets installed, released on Nov 17, i.e. three days ago. That breaks a little integration test suite we are running 1. This is the exception being raised:

AssertionError: {'msg': 'Subject must be a string'}

When downgrading to use pyjwt<2.10, the test suite succeeds again.

You may want to accompany this by potentially adjusting dependencies or code in Apache Superset?

Superset version

3.x and 4.x

Additional context

The software test suite maintained here can be used to reproduce the problem.

We added relevant details to this ticket, where we started to investigate this issue.

Checklist

  • I have searched Superset docs and Slack and didn't find a solution to my problem.
  • I have searched the GitHub issue tracker and didn't find a similar bug report.
  • I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.

Footnotes

  1. ... which orchestrates CLI invocations of the superset program and HTTP calls to the Superset API, in order to validate it works well together with CrateDB.

@amotl
Copy link
Contributor Author

amotl commented Nov 20, 2024

We just found this is most likely the root cause.

The canonical recommendation is to downgrade to PyJWT in the meanwhile.

pip install 'pyjwt<2.10'

@amotl amotl changed the title Problem with PyJWT 2.10 Problem with PyJWT 2.10: Subject must be a string Nov 20, 2024
@amotl
Copy link
Contributor Author

amotl commented Nov 21, 2024

That patch submitted by Dependabot also demonstrates the problem.

@amotl
Copy link
Contributor Author

amotl commented Nov 21, 2024

@jkogut: Do you have any idea why only we might be affected, but Superset's test suite seems to still succeed, and nobody else seems to be tripped? Is it related to the value of the SECRET_KEY maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant