Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trino embedded rows lose their column names #30979

Open
3 tasks done
ilsaloving opened this issue Nov 19, 2024 · 1 comment
Open
3 tasks done

Trino embedded rows lose their column names #30979

ilsaloving opened this issue Nov 19, 2024 · 1 comment
Labels
data:connect:trino Related to Trino sqllab Namespace | Anything related to the SQL Lab

Comments

@ilsaloving
Copy link

Bug description

I am using Trino to connect to Opensearch since Superset doesn't directly support it yet.
When I do a query that contains embedded rows, superset does not display the headers for those rows, showing only "NULL".

I opened a ticket with Trino and they said it has to do with how Superset is calling the API.

trinodb/trino#23758

Screenshots/recordings

image

Superset version

master / latest-dev

Python version

I don't know

Node version

16

Browser

Chrome

Additional context

Actually using 4.0.2 because I haven't been having difficulties trying to extend the docker image.

Logs did not indicate any errors.

Checklist

  • I have searched Superset docs and Slack and didn't find a solution to my problem.
  • I have searched the GitHub issue tracker and didn't find a similar bug report.
  • I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
@dosubot dosubot bot added data:connect:trino Related to Trino sqllab Namespace | Anything related to the SQL Lab labels Nov 19, 2024
@hashhar
Copy link

hashhar commented Nov 20, 2024

For more context, we (trino python client maintainers) had been unable to find a standard way to expose field names for structural types (ROW in Trino's case, similar to STRUCT in BigQuery for example) so we implemented something in trinodb/trino-python-client#335.

Superset can use those methods to retrieve the field names for nested types. Note that we don't use a dict to represent row types because the semantics are different and some valid ROW values cannot be represented as a dict and round-trip and equality becomes problematic so we are not open to changing that decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:connect:trino Related to Trino sqllab Namespace | Anything related to the SQL Lab
Projects
None yet
Development

No branches or pull requests

2 participants