Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Validation of subscription names in the Pulsar broker #23614

Open
1 of 2 tasks
alpreu opened this issue Nov 20, 2024 · 0 comments
Open
1 of 2 tasks

[Enhancement] Validation of subscription names in the Pulsar broker #23614

alpreu opened this issue Nov 20, 2024 · 0 comments
Labels
type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages

Comments

@alpreu
Copy link
Contributor

alpreu commented Nov 20, 2024

Search before asking

  • I searched in the issues and found nothing similar.

Motivation

Currently, for resources like tenants, namespaces, topics the Pulsar broker will do some validation on the naming to ensure a certain format: https://github.com/apache/pulsar/blob/master/pulsar-common/src/main/java/org/apache/pulsar/common/naming/NamedEntity.java

For subscription names however, there is no validation at all, possibly causing issues in downstream systems.

Solution

Introduce a validation for subscription names, similar to what is already done with NamedEntity.

Because this might break things for users currently using such names, it should be optional first so users have time to make the necessary changes.

Alternatives

No response

Anything else?

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@alpreu alpreu added the type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

No branches or pull requests

1 participant