Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail PekkoDiscoveryNameResolver on invalid addresses #333

Open
raboof opened this issue Jun 21, 2024 · 0 comments
Open

fail PekkoDiscoveryNameResolver on invalid addresses #333

raboof opened this issue Jun 21, 2024 · 0 comments

Comments

@raboof
Copy link
Member

raboof commented Jun 21, 2024

ResolvedTarget has an address: Option[InetAddress]. PekkoDiscoveryNameResolver uses that, even when its .getAddress returns null. It would probably be better to fail early and treat this the same as a target with a host without an address that fails to resolve?

(if we change this we probably need to adapt some tests around balancing to test with 'valid but non-responsive' addresses rather than 'invalid' addresses)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant