[core] Make default of 'lookup.local-file-type' to sort #4622
+11
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #xxx
more test after: https://github.com/apache/paimon/pull/4500/files
The sort format have the advantange as below
Writer
Benchmarks also show that sort format has better write performance. However, hash format is optimized for values with the same value, so when values are the same, sort format may be slightly worse.
Reader
testLookupReaderMiss
100000
15000000
The sort format is much better.
testLookupReader (all match)
100000 value
10000000
The hash format only has a certain advantage when the value size is small or the file size does not fill up the cache. In other cases, the sort format is better.
Tests
API and Format
Documentation