[Hive] HiveCatalog: Table StorageDescriptor location and control HMS FileSystem scan. #2760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. fix alter hive Table StorageDescriptor location is empty issue; 2. Add a switch for statistics on file information under Hive Metastore table location, skip HMS FileSystem scan.
JingsongLi
reviewed
Jan 30, 2024
| environmentContext.putToProperties( | ||
| StatsSetupConst.DO_NOT_UPDATE_STATS, StatsSetupConst.TRUE); | ||
| } | ||
| client.alter_table_with_environmentContext( |
There was a problem hiding this comment.
Because we need to support multiple versions of hive, can the alter here be done using reflection and compatible with multiple versions?
You can take a look to iceberg: org.apache.iceberg.hive.MetastoreUtil.
JingsongLi
reviewed
Jan 30, 2024
| @@ -52,5 +52,13 @@ public final class HiveCatalogOptions { | |||
| + "If you don't want to access the location by the filesystem of hive when using a object storage such as s3,oss\n" | |||
| + "you can set this option to true.\n"); | |||
|
|
|||
| public static final ConfigOption<Boolean> TABLE_STATS_SKIP = | |||
There was a problem hiding this comment.
We don't need this, always skip Hive stats.
|
close inactive pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #2729
Tests
API and Format
Documentation