-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track 3rd party libs used in the dist package #17208
Comments
I'll describe one approach - there might be others:
from there ; we could keep a textfile in the project which supposed to match the list of jars in the dist build.
if that list changes; the build should fail There could also be a check to ensure that libs from
|
I was checking this and found two problems as of now
For 1st I found a way to reduce it to max 3 copies which reduced the distribution size from 900M to 600M - #17321 For 2nd I found Maven enforcer rule - https://maven.apache.org/enforcer/enforcer-rules/dependencyConvergence.html |
There is some work done in #16973 that might be usable here. |
Description
It would be great to at least somehow track the 3rd party deps in a way that they need changes to the PR itself if new ones gets added - which will drag attention toward them and could possibly improve the situation.
Motivation
It seems like there are quite a few versions of the same lib in the distribution build - these might have landed via transitive deps and most likely without being considered.
The text was updated successfully, but these errors were encountered: