[fix](source) fix projection and function pushdown not functioning correctly #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinlee19
changed the title
JNSimba
reviewed
May 10, 2024
Comment on lines
203
to
214
| if (StringUtils.isNullOrWhitespaceOnly(readOptions.getFilterQuery())) { | ||
| String filterQuery = resolvedFilterQuery.stream().collect(Collectors.joining(" AND ")); | ||
| this.readOptions.setFilterQuery(filterQuery); | ||
| } | ||
| if (StringUtils.isNullOrWhitespaceOnly(readOptions.getReadFields())) { | ||
| String[] selectFields = | ||
| DataType.getFieldNames(physicalRowDataType).toArray(new String[0]); | ||
| this.readOptions.setReadFields( | ||
| Arrays.stream(selectFields) | ||
| .map(item -> String.format("`%s`", item.trim().replace("`", ""))) | ||
| .collect(Collectors.joining(", "))); | ||
| } |
There was a problem hiding this comment.
What are the benefits of putting it below?
There was a problem hiding this comment.
The method getScanRuntimeProvider is executed before applyProjection. Therefore, initializing readFields in getScanRuntimeProvider will result in querying all fields in Doris, leading to type conversion errors.
vinlee19
changed the title
JNSimba
reviewed
May 11, 2024
flink-doris-connector/src/main/java/org/apache/doris/flink/table/DorisDynamicTableSource.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue 376: close #xxx
Problem Summary:
Describe the overview of changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...