Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration workflow is failing for Rust and nanoarrow #641

Closed
paleolimbot opened this issue Oct 2, 2024 · 0 comments · Fixed by #643
Closed

Integration workflow is failing for Rust and nanoarrow #641

paleolimbot opened this issue Oct 2, 2024 · 0 comments · Fixed by #643

Comments

@paleolimbot
Copy link
Member

The Rust errors are due to apache/arrow-rs#5052, and unfortunately I think it just means we have to disable checking Rust compatibility until the community has the bandwidth to review the fix ( apache/arrow-rs#6426 ).

https://github.com/apache/arrow-nanoarrow/actions/runs/11130234810/job/30929145413#step:3:10644

  FAILED TEST: primitive Rust producing,  nanoarrow consuming
  <class 'subprocess.CalledProcessError'>: Command '/build/nanoarrow/nanoarrow_ipc_integration < /tmp/tmpyz3mdbbr/afddb6c7_generated_primitive.producer_file_as_stream' returned non-zero exit status 22.
  
  FAILED TEST: primitive_zerolength Rust producing,  nanoarrow consuming
  <class 'subprocess.CalledProcessError'>: Command '/build/nanoarrow/nanoarrow_ipc_integration < /tmp/tmpyz3mdbbr/018cdedf_generated_primitive_zerolength.producer_file_as_stream' returned non-zero exit status 22.
  
  FAILED TEST: primitive_large_offsets Rust producing,  nanoarrow consuming
  <class 'RuntimeError'>: Command failed: /build/nanoarrow/nanoarrow_ipc_integration
  With output:
  --------------
  Validating that /tmp/tmpyz3mdbbr/2dffa3bd_generated_primitive_large_offsets.json_as_file reads identical to /tmp/arrow-integration-8826mv00/generated_primitive_large_offsets.json
  Command VALIDATE failed (22=Invalid argument): Footer flatbuffer verification failed (16) vector header out of range or unaligned
  
  --------------

The nanoarrow--nanoarrow error is something about converting swapped endian IPC streams to IPC files since it seems like buffer endian swapping isn't taking place.

https://github.com/apache/arrow-nanoarrow/actions/runs/11130234810/job/30929145413#step:3:10810

FAILED TEST: interval nanoarrow producing,  nanoarrow consuming
  <class 'RuntimeError'>: Command failed: /build/nanoarrow/nanoarrow_ipc_integration
  With output:
  --------------
  Validating that /arrow-integration/testing/data/arrow-ipc-stream/integration/1.0.0-bigendian/generated_interval.arrow_file reads identical to /tmp/tmpyz3mdbbr/1.0.0-bigendian_interval.gold.json
  Command VALIDATE failed (22=Invalid argument): Found 12 differences between batches:
  Path: Batch 0.children[0]
  - {"name": "f1", "count": 7, "VALIDITY": [1, 1, 1, 1, 1, 1, 0], "DATA": ["128", "-129", "-5758134827132877538", "-5984203302733857979", "7152141364016051091", "1946707673701025977", "0"]}
  + {"name": "f1", "count": 7, "VALIDITY": [1, 1, 1, 1, 1, 1, 0], "DATA": ["-9223372036854775808", "9223372036854775807", "2199428923299600048", "4988814404219237292", "-7785723983210331805", "-5113702496382483429", "0"]}
  
  Path: Batch 0.children[1]
  - {"name": "f2", "count": 7, "VALIDITY": [1, 1, 0, 1, 1, 0, 1], "DATA": ["128", "-129", "0", "-8588564788114424009", "4714234549317537763", "0", "-915230144468162553"]}
  + {"name": "f2", "count": 7, "VALIDITY": [1, 1, 0, 1, 1, 0, 1], "DATA": ["-9223372036854775808", "9223372036854775807", "0", "4034946345919434632", "-2085181525232227263", "0", "569773930746957043"]}
  
  Path: Batch 0.children[2]
  - {"name": "f3", "count": 7, "VALIDITY": [0, 0, 1, 1, 1, 1, 1], "DATA": ["0", "0", "-91386228020645345", "8297967703166746363", 
  
@paleolimbot paleolimbot added this to the nanoarrow 0.6.0 milestone Oct 2, 2024
paleolimbot added a commit that referenced this issue Oct 7, 2024
Closes #641.

Unfortunately we just have to skip checking Rust compatibility due to
apache/arrow-rs#5052 (e.g.,
apache/arrow-rs#6449 ).

This PR also ensures compatibility with big endian Arrow files and Arrow
files from before the continuation token. Support for those had already
been added in the decoder but hadn't made it to the stream reader yet.

Local check:

```bash
# Assumes arrow-testing, arrow-nanoarrow, and arrow are all checked out in the same dir
export gold_dir=../arrow-testing/data/arrow-ipc-stream/integration 
export ARROW_NANOARROW_PATH=$(pwd)/build 
pip install -e "../arrow/dev/archery/[all]"
archery integration --with-nanoarrow=true --run-ipc \
    --gold-dirs=$gold_dir/0.14.1 \
    --gold-dirs=$gold_dir/0.17.1 \
    --gold-dirs=$gold_dir/1.0.0-bigendian \
    --gold-dirs=$gold_dir/1.0.0-littleendian \
    --gold-dirs=$gold_dir/2.0.0-compression \
    --gold-dirs=$gold_dir/4.0.0-shareddict
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant