Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Course nickname doesn't apply in Course Dashboard if there's ellipsis #242

Open
KTibow opened this issue Jan 7, 2021 · 5 comments
Open
Assignees
Labels
Bug Something that doesn't work, but should
Milestone

Comments

@KTibow
Copy link
Contributor

KTibow commented Jan 7, 2021

Describe the bug
If a course has a long name and gets abbreviated, a nickname doesn't apply.

To Reproduce

  1. Find a course with a long name
  2. Give it a nickname
  3. Go to Course Dashboard
  4. Resize window to small size
  5. See nickname not working

Expected behavior
The nickname to be replaced

Screenshots
Nickname was School Counselor
image

Additional context
This might be hard, given that Schoology splits the name into separate elements.

Info: Edge 87.0.664.66, with Windows build 19042, at https://nsd.schoology.com/, 6.7.1

@KTibow KTibow added the Bug Something that doesn't work, but should label Jan 7, 2021
@aopell aopell modified the milestone: v7.X Jan 8, 2021
@aopell
Copy link
Owner

aopell commented Jan 8, 2021

Depending on how this is represented in the HTML it could be impossible. @glen3b would be more familiar though

@aopell aopell added this to the v7.X milestone Jan 8, 2021
@KTibow
Copy link
Contributor Author

KTibow commented Jan 8, 2021

I think you could do this by getting the aria-label of the section.sgy-card element.

@glen3b
Copy link
Collaborator

glen3b commented Jan 10, 2021

IIRC we handle the course dropdown specially for a variety of reasons. I'll take a look and see if I can reproduce this.

@glen3b glen3b changed the title Course nickname doesn't apply if there's ellipsis Course nickname doesn't apply in Course Dashboard if there's ellipsis Jan 12, 2021
@glen3b
Copy link
Collaborator

glen3b commented Jan 12, 2021

Clarifying: this is the course dashboard, as in the homescreen "tab," and not the dropdown, correct? I'm making sure we're disambiguated from #246.

@KTibow
Copy link
Contributor Author

KTibow commented Jan 12, 2021

Correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something that doesn't work, but should
Projects
None yet
Development

No branches or pull requests

3 participants