From 2ebbd199dc1dc31b17a8d23ecbd2487b241cfd88 Mon Sep 17 00:00:00 2001 From: dsnsgithub <48170013+dsnsgithub@users.noreply.github.com> Date: Mon, 22 Jan 2024 23:13:41 -0800 Subject: [PATCH 1/5] fix bugged percent --- css/grades.css | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/css/grades.css b/css/grades.css index f7d1c58..9978871 100644 --- a/css/grades.css +++ b/css/grades.css @@ -20,6 +20,11 @@ div.tier-injected-score { text-align: right; } +/* this needs to be on its own to be more specific and override schoology */ +.td-content-wrapper { + display: block !important; +} + .grade-column-center { text-align: center !important; padding-right: 10px !important; From 805cfd319d02ad0c4448dcad9e4a0c884f81601d Mon Sep 17 00:00:00 2001 From: Aaron Opell Date: Tue, 23 Jan 2024 18:13:29 -0800 Subject: [PATCH 2/5] Fix grades page CSS and remove link to form --- css/grades.css | 4 ++-- js/grades.js | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/css/grades.css b/css/grades.css index 9978871..efe097d 100644 --- a/css/grades.css +++ b/css/grades.css @@ -2,6 +2,7 @@ float: right; font-weight: bold; font-size: 14px; + padding-right: 20px; } tr.item-row td.grade-column div.td-content-wrapper { @@ -20,8 +21,7 @@ div.tier-injected-score { text-align: right; } -/* this needs to be on its own to be more specific and override schoology */ -.td-content-wrapper { +.gradebook-course.hierarchical-grading-report .gradebook-course-grades .td-content-wrapper { display: block !important; } diff --git a/js/grades.js b/js/grades.js index 7594695..f1cd81b 100644 --- a/js/grades.js +++ b/js/grades.js @@ -653,8 +653,8 @@ var fetchQueue = []; else if (editDisableReason && !editDisableReason.allCausedBy403) { Logger.error("Editing disabled due to error", editDisableReason); - if (confirm("Grade editing has been disabled due to an error. If you are trying to use What If Grades on the grade report page, try going to an individual class gradebook instead. Would you like to report this issue? (It will help us fix it faster!)")) { - window.open(`${BUG_REPORT_FORM_LINK}${encodeURIComponent(JSON.stringify(editDisableReason))}`, "_blank"); + if (confirm("Grade editing has been disabled due to an error. If you are trying to use What If Grades on the grade report page, try going to an individual class gradebook instead. If you are consistently getting this error, please reach out to the Schoology Plus Discord server.")) { + // window.open(`${BUG_REPORT_FORM_LINK}${encodeURIComponent(JSON.stringify(editDisableReason))}`, "_blank"); } document.getElementById("enable-modify").checked = false; @@ -662,8 +662,8 @@ var fetchQueue = []; // enabling editing else if (document.getElementById("enable-modify").checked) { if (editDisableReason && editDisableReason.allCausedBy403) { - if (confirm("WARNING!!!\n\nYou have one or more missing assignments for which the total points are unknown due to restrictions put in place by your teacher. Grade editing may work in some categories if this is a weighted gradebook, however it will be disabled in others. We are working on a fix for this issue, but until then please click 'OK' to submit a bug report so we can gague how large this problem is. Thank you!")) { - window.open(`${BUG_REPORT_FORM_LINK}${encodeURIComponent(JSON.stringify(editDisableReason))}`, "_blank"); + if (confirm("WARNING!!!\n\nYou have one or more missing assignments for which the total points are unknown due to restrictions put in place by your teacher. Grade editing may work in some categories if this is a weighted gradebook, however it will be disabled in others.")) { + // window.open(`${BUG_REPORT_FORM_LINK}${encodeURIComponent(JSON.stringify(editDisableReason))}`, "_blank"); } } From e8778a3215db337c426b518d698a7dc66dbcfcf1 Mon Sep 17 00:00:00 2001 From: Aaron Opell Date: Tue, 23 Jan 2024 18:19:32 -0800 Subject: [PATCH 3/5] prevent page reload when viewing api key --- js/api-key.js | 1 + 1 file changed, 1 insertion(+) diff --git a/js/api-key.js b/js/api-key.js index 0413935..87ee782 100644 --- a/js/api-key.js +++ b/js/api-key.js @@ -89,6 +89,7 @@ let submitButton = document.getElementById("edit-reveal") || document.getElementById("edit-request"); submitButton.value = "Reveal Existing Secret"; submitButton.parentElement.classList.remove('splus-allow-access'); + document.location.search = "showkey"; } } ), ]), ]) From eebf388eaa7ccf714b02dc7b4dea3f3a299c6e9a Mon Sep 17 00:00:00 2001 From: Aaron Opell Date: Tue, 23 Jan 2024 18:30:37 -0800 Subject: [PATCH 4/5] Add setting to remove powerschool logo --- css/all.css | 8 ++++++-- js/preload.js | 14 +++++++------- 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/css/all.css b/css/all.css index ad53d0b..545e8c6 100644 --- a/css/all.css +++ b/css/all.css @@ -650,8 +650,12 @@ the selector matches inside notifications in the new notifs dropdown left: calc(50vw - 300px) !important; } -._pendo-launcher-badge_ { - visibility: var(--help-center-fab-visibility) !important; +svg:has(+ div.CustomBrandingLogo-vertical-strip-background-color-3_NIE) { + display: var(--power-school-logo-display) !important; +} + +div.CustomBrandingLogo-vertical-strip-background-color-3_NIE { + display: var(--power-school-logo-display) !important; } .quick-link-wrapper { diff --git a/js/preload.js b/js/preload.js index da288c5..43878eb 100644 --- a/js/preload.js +++ b/js/preload.js @@ -622,25 +622,25 @@ function updateSettings(callback) { element => element.value ).control, new Setting( - "helpCenterFAB", - "Schoology Help Button", - "Controls the visibility of the S button in the bottom right that shows the Schoology Guide Center", - "hidden", + "powerSchoolLogo", + "PowerSchool Logo", + "Controls the visibility of the PowerSchool logo on the navigation bar", + "block", "select", { options: [ { text: "Show", - value: "visible" + value: "block" }, { text: "Hide", - value: "hidden" + value: "none" } ] }, value => { - setCSSVariable("help-center-fab-visibility", value); + setCSSVariable("power-school-logo-display", value); return value; }, function (event) { this.onload(event.target.value) }, From fb6531ed13eb39b984d1b13655d13dea8a1ff368 Mon Sep 17 00:00:00 2001 From: Aaron Opell Date: Tue, 23 Jan 2024 18:31:23 -0800 Subject: [PATCH 5/5] bump version --- manifest.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/manifest.json b/manifest.json index e7acd4e..7b8873a 100644 --- a/manifest.json +++ b/manifest.json @@ -10,7 +10,7 @@ "update_url": "https://schoologypl.us/firefox_updates.json" } }, - "version": "7.8.6", + "version": "7.9", "icons": { "128": "imgs/icon@128.png", "64": "imgs/icon@64.png",