Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHP] make BaseListener / BaseVisitor abstract by default #4737

Open
dkarlovi opened this issue Nov 26, 2024 · 0 comments
Open

[PHP] make BaseListener / BaseVisitor abstract by default #4737

dkarlovi opened this issue Nov 26, 2024 · 0 comments

Comments

@dkarlovi
Copy link

The BaseListener / BaseVisitor classes do nothing by default, they should be marked as abstract to signal it's not meant to be used directly (because it makes no sense to do so) but extended.

See #4450, should get extended to BaseVisitor too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dkarlovi