Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yearDiscovered should give an approximate year if possible #10

Open
andrejewski opened this issue Oct 17, 2016 · 1 comment
Open

yearDiscovered should give an approximate year if possible #10

andrejewski opened this issue Oct 17, 2016 · 1 comment

Comments

@andrejewski
Copy link
Owner

Some elements have their year of discovery marked as "Ancient" which I'd like to narrow down to at least some approximate integer date (even if it is a negative to represent BC). This adds more context to the data but also better normalizes it so users don't have to check for number or string when working with the values.

@sabidhasan
Copy link

My suggestion would be to use -infinity as the value

This way, you have a datatype of number and still keep the "unknown" factor. Some elements we really can't put a date on, even roughly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants