Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

findOnce break after the first child node. #67

Open
knuppe opened this issue Jan 24, 2021 · 0 comments
Open

findOnce break after the first child node. #67

knuppe opened this issue Jan 24, 2021 · 0 comments

Comments

@knuppe
Copy link

knuppe commented Jan 24, 2021

If the element is not found in the first child node, the value is returned, and the loop has no effect.

I think this should be if q {

for c := n.FirstChild; c != nil; c = c.NextSibling {
	p, q := findOnce(c, args, true, strict)
	if !q {
		return p, q
	}
}

soup/soup.go

Line 504 in cb47551

if q != false {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant