feat: add support for macos #156
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One thing I did notice, is that "Device Type" isn't available when running on MacOS. However, I don't think it has to do with this Flutter package, it might be an issue with Amplitude-iOS. edit: I tried overriding the event from the Flutter side of things by using the |
|
@justin-fiedler any chance we could get this merged in? |
|
@jointhejourney Thanks for created this pull request. We are in the process of updating the flutter SDK to use our newer iOS and Android SDKs. So ideally, we'd want to use the macos support in our swift SDK. I'll keep this thread updated on an ETA on when this will be made available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
Our Flutter app, Journey Navigation, utilizes Amplitude for our iOS app and we wanted to use it for our MacOS app as well.
I took advantage of the
sharedDarwinSourceoption, since the Amplitude-iOS package is compatible with MacOS. The changes are fairly straightforward, and everything seems to work ok.Fixes #46