Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.1.7 broken our Android build. #123

Open
idunnololz opened this issue Jul 31, 2023 · 1 comment
Open

Release 1.1.7 broken our Android build. #123

idunnololz opened this issue Jul 31, 2023 · 1 comment

Comments

@idunnololz
Copy link

Updating to 1.1.7 broke our release build for our Android app. This appears to involve R8 + kotlinx-datetime which was added in this commit: 9f60270.

It looks like kotlinx-datetime uses kotlinx.serialization and kotlinx.serialization requires some specific proguard rules to work. See https://github.com/Kotlin/kotlinx.serialization#android.

The easiest way to reproduce this is to create a new Android app. Ensure Android Gradle Plugin in 8 or higher. Add json-logic-kmp v1.1.7 and then do a release build.

@PaulinaSadowskaAllegro
Copy link
Collaborator

Thanks for the report!
Would you like to propose a change in the library that fixes that issue in the PR? We'll be happy to review and release it. I added you as a collaborator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants