Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation side bar (#1904) #1914

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Navigation side bar (#1904) #1914

wants to merge 1 commit into from

Conversation

maknik
Copy link

@maknik maknik commented Oct 16, 2024

Screenshot 2024-10-16 at 21 02 06

szczygiel-m
szczygiel-m reviewed Oct 30, 2024
View reviewed changes
Copy link
Contributor

@szczygiel-m szczygiel-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR! 😄

hermes-console/src/components/navigation-drawer/NavigationDrawer.vue
<template v-if="!isLoggedIn">
<v-list>
<v-list-item
:prepend-avatar="`https://alleavatar.allegrogroup.com/${userData.user_name}.jpg`"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is opensourced repository we can't hardcode such internal links. We should remove it or make it a configurable string, but the second option would require more changes also on the backend site of hermes-management.

Copy link
Contributor

@pitagoras3 pitagoras3 Nov 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Mateusz, could you remove this?

pitagoras3
pitagoras3 requested changes Nov 8, 2024
View reviewed changes
hermes-console/src/store/auth/useAuthStore.ts
return state.accessToken ? jwtDecode(state.accessToken) : { exp: 0 };
userData(state: AuthStoreState): {
exp: number;
full_name: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: Here, we implicitly expect that JWT contains full_name and user_name in the token.

This may not be true for our Open Source users. I would suggest to simplify the sidebar, by removing info about logged in user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szczygiel-m szczygiel-m szczygiel-m left review comments

@pitagoras3 pitagoras3 pitagoras3 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maknik @pitagoras3 @szczygiel-m