Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider changing current approach to rate limiting for filters #1331

Open
piotrrzysko opened this issue Mar 23, 2021 · 1 comment
Open

Consider changing current approach to rate limiting for filters #1331

piotrrzysko opened this issue Mar 23, 2021 · 1 comment
Labels

Comments

@piotrrzysko
Copy link
Member

Currently, there are two separate rate limiting mechanisms:

Both share the same configuration (property Rate limit from the configuration of subscription).

With the current approach when we have a subscription where most of the messages are filtered out we may easily reach a filtering rate-limiter threshold. As a consequence, Hermes will slow down sending messages to the subscriber. This in turn may lead to a high lag even though the subscriber might handle more traffic.

Perhaps splitting configuration should help, but we have to be careful about processing too many messages for one subscription as it may cause the starvation of other subscriptions.

@druminski
Copy link
Contributor

Related issue #656

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants