Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuring versionIncrementer is cumbersome in Kotlin DSL #841

Open
radoslaw-panuszewski opened this issue Oct 15, 2024 · 0 comments
Open

Comments

@radoslaw-panuszewski
Copy link
Collaborator

Expected behavior

scmVersion {
    versionIncrementer = PredefinedVersionCreator.INCREMENT_MINOR.versionIncrementer
}

Current behavior

scmVersion {
    versionIncrementer = VersionProperties.Incrementer { it.currentVersion.incrementMinorVersion() }
}

Context

There are 2 interfaces: PredefinedVersionIncrementer.VersionIncrementer and VersionProperties.Incrementer. The latter is exposed to DSL via VersionConfig.getVersionIncrementer() but PredefinedVersionIncrementer implements the former.

The similar config versionCreator has only one interface VersionProperties.Creator and PredefinedVersionCreator implements it. We should do it the same way for versionIncrementer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant