Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Previous version is the same as current version when building tags #395

Open
mockitoguy opened this issue Mar 31, 2021 · 3 comments · May be fixed by #413
Open

Previous version is the same as current version when building tags #395

mockitoguy opened this issue Mar 31, 2021 · 3 comments · May be fixed by #413

Comments

@mockitoguy
Copy link

In the recent release we've added scmVersion.previousVersion. It works well for snapshots but does not quite work when building tags:

  • when building snapshots: scmVersion.version=1.0.0, scmVersion.previousVersion=1.0.1-SNAPSHOT
  • when building tags: scmVersion.version=1.0.1, scmVersion.previousVersion=1.0.1

Since I'm in need of this feature, I'll take a look ;-)
@bgalek
Copy link
Member

bgalek commented Mar 31, 2021

@mockitoguy thx ;)

@mockitoguy mockitoguy mentioned this issue Apr 9, 2021
Open
@EisenRatte EisenRatte linked a pull request Jul 29, 2021 that will close this issue
Open
@EisenRatte
Copy link

in my opinion this is a bug and should therefore be fixed instead of adding another property.
i created a PR #413

@bgalek
Copy link
Member

bgalek commented Oct 6, 2021

@mockitoguy what do you think? Should we be discussing your PR or #413 way?:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixed previousVersion for tagged commits EisenRatte/axion-release-plugin
3 participants
@mockitoguy @bgalek @EisenRatte