-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change incremented part and prerelease from command line #157
Comments
I'm confused by transitioning from 0.1.1 to 0.1.1-beta1 here. Shouldn't it be 0.1.2-beta1? |
Yes, you are right - it should bump patch as well. I will update the main description. BTW what do you think of this concept? I'm afraid it might be too complex, but on the other hand i see no simpler solution. |
This proposal introduces many new concepts and I'd say the logic for finalize may be tricky for end user... Alternatively we might try to to use the same ubiquitous language as we have in gradle configuration layer. Assuming that we have
|
Few comments to the example above:
|
AFAIR Rationale behind mine proposal was making this mechanism easy to port to some kind of task name pattern matching like So, i'm leaning towards @vbuell proposal, especially that it is just a simple extension of existing settings and if we need something more sophisticated it will be easy to achieve in the future. |
I wonder if it would be possible to combine |
According to the proposal (and vbuell proposition) this is exactly what you gonna get:
Don't know about this |
I was rather thinking about potential implementation to support those mixes. Semver is fine with dots. From their webpage:
The implementation could try to find a number at the end and increase it:
|
Yes, when running release on prerelease version it is incremented if possible. We already have |
@szpak axion is already able to increment versions like |
Great. I plan to use it soon :). |
Hi @adamdubiel @vbuell could you please add more doc about pre-release in command line
|
Hi @szpak |
As far as i understand, you agreed in 2016 how the Prerelease and finalization should be handled but then in never got implemented!?!? is that so? |
Hi, This is exactly what our release flow requires and would be a nice flexible API for this plugin too.
(I need to keep track of RCs, and mark the last RC later as final because I have remote parties who can decide whether it is a go or no-go.)
|
@gergely-sallai how do You feel about a contribution? :) |
This is a proposal for solving problem discussed in #142
Problem
Creating versions like:
1.0.0-beta1
in a dynamic and generic way, without defining customversionIncrementor
.Proposed solution
Add three new parameters:
release.increment
optional parameter has one of 4 fixed values:major
,minor
,patch
,prerelease
and determines which part of version should be incremented in this release:release.prerelease
optional parameter can have any value (ascii, single word, no numbers) and adds prerelease modifier to version:release.finalize
optional parameter denotes that this release should not increment any numbers but remove prerelease values or replace prerelease with unnumbered new prerelease:Behaviour
increment
always defaults to the smallest part of version:prerelease
defaults to:The text was updated successfully, but these errors were encountered: