Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifications are generally annoying and not useful #42

Open
alexmurray opened this issue Mar 24, 2023 · 0 comments
Open

Notifications are generally annoying and not useful #42

alexmurray opened this issue Mar 24, 2023 · 0 comments

Comments

@alexmurray
Copy link
Owner

Currently notifications are shown when an error occurs reading from a sensor or when a sensor alarms. But in both cases there is no real action the user can take. We should not use notifications in general and be smarter - ie. Show an 😵 or similar on sensor error for the value and perhaps one notification saying that the error occurred, which we then hide if the error stops.

Also since no action can be taken for alarm conditions, don't show a notification for these but instead change the icon to indicate the alarm is active.
alexmurray added a commit that referenced this issue Mar 25, 2023
@alexmurray
indicator-sensors/is-sensor.c: don't show notification on alarm
62d576b 
There is nothing the user can do in this case so don't bother showing a
notification, this is just noise.

Issue #42.

Signed-off-by: Alex Murray <[email protected]>
alexmurray added a commit that referenced this issue Mar 25, 2023
@alexmurray
indicator-sensors/is-sensor.c: track error state
4e2e940 
Previously when the error state was set for a sensor we would clear the old
state and set the new one, without checking if they were the same. But this
would result in a closing of the existing notification and showing of a new one
with the same contents.

In general it can be useful to let the user know that the sensor has encountered
and error BUT we don't want to do this every time the sensor value is tried to
be read. So check if the new error condition is different and only then take any
action, that way we won't close and redisplay the same notification.

Issue #42.

Signed-off-by: Alex Murray <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexmurray