Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Add an autolabels section to DEREK.yml to automatically label issues #33

Open
rgee0 opened this issue Jan 24, 2018 · 10 comments

Comments

@rgee0
Copy link
Contributor

rgee0 commented Jan 24, 2018

Add an autolabels section to DEREK.yml so that any issues raised containing the words within this section are automatically labelled:

e.g.

autolabels:
    - proposal
    - question
    - enhancement

Also add - autolabels to the features section to enable/disable

@derek derek bot added the proposal label Jan 25, 2018
@alexellis
Copy link
Owner

This would be useful for us - will it be generic enough to support the requirements from Puppet?

@rgee0
Copy link
Contributor Author

rgee0 commented Feb 7, 2018

The Puppet requirement may require a mapping:

autolabels:
    - keyword: 'labelToApply'

This would provide a greater level of flexibility.

@alexellis
Copy link
Owner

Valid YAML may be:

autolabels:
    - name: keyword
       value: labelToApply

Still.. let's work to an MVP before embellishing - I'll post this into the #derek channel

@davejrt
Copy link

davejrt commented Feb 7, 2018

As a first step this looks great. We've got some other unique requirements at puppet that we may end up needing later down the track, so notifying someone on a PR if their unit test didn't pass in travis...or they've not included a puppet manifest, the puppet version, OS version in the text in their issue. Based on that we might want Derek to comment and say, you've not included this, in much the say way it responds to PRs now that don't have dco sign off

@alexellis
Copy link
Owner

Ok.. do you have some examples of the labels you'd like @davejrt ?

@davejrt
Copy link

davejrt commented Feb 25, 2018

Bug
Enhancement
Question

Those are probably the three we use most commonly.

@alexellis
Copy link
Owner

Same here.. these are quite subjective labels though. One thing I wanted to start for OpenFaaS was labelling for different areas.

area/swarm
area/kubernetes
area/watchdog

etc

@alexellis
Copy link
Owner

We ask for the information on the system in the issue template so the auto-labels here would be really useful from the start. (via @rgee0 )

@alexellis
Copy link
Owner

Since Derek had some original inspiration from Docker's Poule tool by @icecrime I thought we could refer to Arnaud's concept on a keywords -> labels mapping:

https://github.com/moby/moby/blob/master/poule.yml#L23

What do we think?

@rgee0
Copy link
Contributor Author

rgee0 commented Nov 7, 2018

I think the approach makes sense, albeit configured via the yaml for versatility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants