-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Track rate limiting from GitHub API #19
Comments
A couple of initial notes while thinking.
The limit appears to be distinct time-slices rather than a sliding window. |
Hmm is that a proposed API or a GH thing? |
We could definitely track it in alertmanager and send through to a webhook. |
Derek add label: priority/high |
I wonder if we should write a small function as a prometheus exporter which can produce this information for all the installations we have registered. It may involve us collecting the installation messages when the GitHub app is registered. |
https://developer.github.com/v3/#rate-limiting The remaining limit is in the We could fire off some event when this gets low |
Context
When authenticated we have 50 requests to the API / hour. When we are authenticated we have 5k per hour +/-.
Idea: track rate-limiting
It's unlikely that we will burn up 5k in an hour on the OpenFaaS org, but larger projects may hit this and this should be observable.
What do we do?
How do we track this?
The text was updated successfully, but these errors were encountered: