Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time menu counter increment delay is slightly too much. #50

Open
akshat157 opened this issue Oct 19, 2021 · 5 comments
Open

Time menu counter increment delay is slightly too much. #50

akshat157 opened this issue Oct 19, 2021 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Open for contributions during Hacktoberfest!

Comments

@akshat157
Copy link
Owner

Along with #47, the time menu counter's increase and decrease buttons should work on a mouse press and hold as well until the limit is reached. This will make for a better UX as there are so many duration options.

@akshat157 akshat157 added enhancement New feature or request good first issue Good for newcomers hacktoberfest Open for contributions during Hacktoberfest! labels Oct 19, 2021
@nguyenhung15913
Copy link

Hi, @akshat157 , I am interested in this issue. Can you assign it to me? Thanks

@akshat157
Copy link
Owner Author

Hi @nguyenhung15913. It looks like #52 solves this issue as well. However, the delay of 450ms is slightly too long for a press and hold. If you like, you can reduce that delay as part of fixing this issue and I will merge that PR.

Something like 100-200ms will be a little better. You can try different values but keep it lesser than the current delay.

@akshat157 akshat157 changed the title Time menu counter should work with mouse press and hold. Time menu counter increment delay is slightly too much. Oct 20, 2021
@kushalShukla-web
Copy link

Can I contribute in it

@akshat157
Copy link
Owner Author

@kushalShukla-web Hi, sure! You can do the changes I've requested in my previous comment on this thread.

@manaver
Copy link

manaver commented Sep 23, 2022

Hi akshat157, I am interested in this issue. Can you assign to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Open for contributions during Hacktoberfest!
Projects
None yet
Development

No branches or pull requests

4 participants