Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect build instructions #119

Open
fgm opened this issue Sep 13, 2021 · 0 comments
Open

Incorrect build instructions #119

fgm opened this issue Sep 13, 2021 · 0 comments

Comments

@fgm
Copy link

fgm commented Sep 13, 2021

Problem description

With the current "Build and test" instructions in the readme:

  • there is an error on vagrant up because the https://github.com/smartystreets/assertions package now needs Go 1.13 (for errors.Is but the VM provides Go 1.9
  • the go test ./... instructions don't work because /go is root:root but the VM guest user id vagrant:vagrant so the go tool can't download the dependencies
  • when adding a such chown -R vagrant:vagrant /go the go tool downloads success, but the build fails because of https://github.com/smartystreets/assertions dependency on Go 1.13 again.

Suggested changes

  • In the short term, upgrade to Go 1.17 since this is the current version
  • In the longer term convert to docker for ease of use/speed.
fgm pushed a commit to fgm/hystrix-go that referenced this issue Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant